Fix comments between headers (#447) #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsenart
previously approved these changes
Oct 27, 2019
mbodock
force-pushed
the
fix-comment-in-headers
branch
from
841603d to
e1fe2ce
Compare
|
@tsenart Applied the suggestion, nice catch! Also rebased with master in upstream. Please let me know if you need anything else. |
tsenart
previously approved these changes
Oct 28, 2019
|
One last request: Please update the relevant sections of the README with this added functionality. |
Add the possibility to add comment between headers Fixes tsenart#447
mbodock
force-pushed
the
fix-comment-in-headers
branch
from
e1fe2ce to
5b56346
Compare
|
Just removed the part about targets. This should be enough since my first usage I already expected to be able to use comments anywhere. |
tsenart
approved these changes
Oct 28, 2019
|
Hello @tsenart, thank you very much for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Closes issue #447
Sometimes is nice to provide more information about a specific header, specially when sharing targets files. For this reason would be nice be able to put comments in the header section.
Checklist